Use lexicographic distance as last chance to spot the right library #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Should solve most "overload" cases in Create. Eg: Library ZZ_Sensor contains ZZ_Sensor.h but the name in library.properties is "ZZ Unified Sensor" A sketch includes ZZ_Sensor.h and the resolve function fails every test (since the library name is not contained in any variation of the "include" string), so it uses another clashing library randomly. Lexicographic distance should help avoiding any library with "very different" name (unless explicitely requested, of course).
facchinm
force-pushed
the
lexicographic_distance_as_last_chance
branch
from
350621e to
eff1eeb
Compare
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
cmaglie
added a commit
to arduino/arduino-cli
that referenced
this pull request
Apr 12, 2019
mastrolinux
pushed a commit
to arduino/arduino-cli
that referenced
this pull request
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve most "overload" cases in Create.
Eg:
Library ZZ_Sensor contains ZZ_Sensor.h but the name in library.properties is "ZZ Unified Sensor"
A sketch includes ZZ_Sensor.h and the resolve function fails every test (since the library name is not contained in any variation of the "include" string), so it uses another clashing library randomly.
Lexicographic distance should help avoiding any library with "very different" name (unless explicitly requested, of course).
@cmaglie @mbanzi @mastrolinux @rsora