Remove composite paths support from foldersFlag #277
Conversation
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
arduino-builder/main.go
Outdated
| @@ -97,17 +97,8 @@ func (h *foldersFlag) String() string { | |||
| } | |||
|
|
|||
| func (h *foldersFlag) Set(csv string) error { | |||
There was a problem hiding this comment.
The csv variable should be renamed to folder.
arduino-builder/main.go
Outdated
| *h = append(*h, value) | ||
| } | ||
| csv = strings.TrimSpace(csv) | ||
| *h = append(*h, csv) |
There was a problem hiding this comment.
Should we also remove the TrimSpace here? With it, you cannot have use directory name ending or starting in a space (which is unlikely to be useful, but why not just allow any filename?). A shell will trim spaces anyway, unless someone takes the effort to escape them (in which case we shouldn't trim them again)?
|
@matthijskooijman you are right about the rename, also the second one looks like an artificial limitation but we have to make sure that removing the trim brings no side effect |
Fixes arduino#276 The only supported way to append multiple hardware/tools folders becomes specifying the same flag multiple times (which is the de-facto standard, since the Java IDE only uses this format)
facchinm
force-pushed
the
fix_comma_folder
branch
from
d66e34f to
e94b3ee
Compare
|
❌ Build failed. |
Fixes #276
The only supported way to append multiple hardware/tools folders becomes specifying the same flag multiple times (which is the de-facto standard, since the Java IDE only uses this format)
@matthijskooijman