Fix UTF8 filenames not being matched by gcc -e output parsing #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Implementation borrowed from net/mail package (message.go) Solves arduino/Arduino#5277 Signed-off-by: Martino Facchin <[email protected]>
facchinm
force-pushed
the
utf8_strings
branch
from
ee9a093 to
ed4f683
Compare
|
Superseded by #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from 81eadf3,
ctagsis fed only with sketch code after thegcc -epass.If the filename contains non-ASCII characters, the string matching at https://github.com/arduino/arduino-builder/blob/master/src/arduino.cc/builder/filter_sketch_source.go#L59 returns
falsebecauseutils.ParseCppStringonly treats ASCII strings.This patch fixes this behaviour and adds some tests to demonstrate the functionality. All tests are passing.