Allow the builder to be aware of package_index properties #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
force-pushed
the
json_parsing_properties
branch
from
a77447d to
f9da823
Compare
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
IDE builds will appear here arduino/Arduino#5197 |
|
Putting this PR in standby until we understand the future architecture of IDE related tools |
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Works with folders, filenames and urls
Will be used to pass folders containing package_index jsons
will map into "packager" field of the json
Only works if a valid package_index json has been provided
To overcome https://github.com/arduino/Arduino/issues/5168, find a better way please :)
Inherits all tools from latest version of a specific core
"coreDependencies": [
{
"packager": "arduino",
"name": "avr"
}
]
The coreDependency resolution will search for most recent installed core. The test has been moved to allow populating the context
This leaves non-derived cores (like MightCore or Cosa) the freedom to specify their own tools (overriding avr 1.6.12 lto requirement)
cmaglie
force-pushed
the
json_parsing_properties
branch
from
f9da823 to
2eb6732
Compare
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
Superseded by arduino-cli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVR core 1.6.12 introduced a new toolchain but the mighty builder still had no clue about it. There is no magic in there, simply some key->value substitution which accidentally lead to a massive breakage, both for arduino avr core and for 3rd party cores.
To solve this issue in a sane way (but without providing a full package manager yet) this PR introduces a library (
json_package_index) which parses the provided package_index folder, extracts the useful information from there and uses these information to avoid breaking the build.Passing
-package-indexflag with a folder will allow the builder to know which version is needed by any core.I'll update this PR as soon as we'll start testing it massively (a link to the IDE PR builds will come soon)