Skip to content

Dependency parsing: if a file is not found trigger a full rebuild #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2016

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 4, 2016

The missing file is probably due to a parsing error, better to trigger a rebuild in this case instead of exiting with an error. This is a quick workaround, the full solution is to properly parse .d files.

Fix #136

The missing file is probably due to a parsing error, better to trigger a
rebuild in this case instead of exiting with an error.
This is a quick workaround, the full solution is to properly parse .d
files.

Fix arduino#136

Signed-off-by: Cristian Maglie <[email protected]>
@cmaglie cmaglie self-assigned this May 4, 2016
@cmaglie cmaglie added this to the 1.3.17 milestone May 4, 2016
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-142.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@cmaglie
Copy link
Member Author

cmaglie commented May 4, 2016

@ghlawrence2000 may you try this version of arduino-builder following the instructions above from ArduinoBot?

@cmaglie cmaglie merged commit 28f242e into arduino:master May 5, 2016
@cmaglie cmaglie deleted the quick-fix-dep-parsing branch May 5, 2016 16:24
@ghlawrence2000
Copy link

@cmaglie GREAT!!! That works perfectly, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants