Skip to content

resubmit with signed off - added exception for incorrect board name string #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

CatherineH
Copy link
Contributor

I just started using arduino-builder a few days ago, and was confused when I got the error:

$ arduino-builder -fqbn teensyLC -hardware ~/arduino-1.6.7/hardware/ -tools ~/arduino-1.6.7/tools experiment_control.ino
panic: runtime error: index out of range

goroutine 1 [running]:
arduino.cc/builder.(*TargetBoardResolver).Run(0x6c3050, 0xc20803c4e0, 0x0, 0x0)
    ~/arduino-builder/src/arduino.cc/builder/target_board_resolver.go:46 +0xf44
arduino.cc/builder.(*ContainerSetupHardwareToolsLibsSketchAndProps).Run(0x6c3050, 0xc20803c4e0, 0x0, 0x0)
    ~/arduino-builder/src/arduino.cc/builder/container_setup.go:59 +0x6b8
arduino.cc/builder.runCommands(0xc20803c4e0, 0xc20802db90, 0x1d, 0x1d, 0x418001, 0x0, 0x0)
    ~/arduino-builder/src/arduino.cc/builder/builder.go:187 +0x139
arduino.cc/builder.(*Builder).Run(0xc20802dd88, 0xc20803c4e0, 0x0, 0x0)
    ~/arduino-builder/src/arduino.cc/builder/builder.go:118 +0xef7
arduino.cc/builder.RunBuilder(0xc20803c4e0, 0x0, 0x0)
    ~/arduino-builder/src/arduino.cc/builder/builder.go:218 +0x49
main.main()
    ~/arduino-builder/main.go:333 +0x1eb2

With this pull request, the new error message is:

$ arduino-builder -fqbn teensyLC -hardware ~/arduino-1.6.7/hardware/ -tools ~/arduino-1.6.7/tools experiment_control.ino
teensyLC is not a valid fully qualified board name. Required format is targetPackageName:targetPlatformName:targetBoardName.

cmaglie added a commit that referenced this pull request May 4, 2016
Signed-off-by: Cristian Maglie <[email protected]>
@cmaglie cmaglie added this to the 1.3.17 milestone May 4, 2016
@cmaglie
Copy link
Member

cmaglie commented May 4, 2016

I've merged 6a48e71 and skipped all the merge commits. I've also ported the implementation to the new context layout, see b71154d.

Thank you!

@cmaglie cmaglie closed this May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants