Skip to content

Rebuild of core.a, even when none of its .o files have changed #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaulStoffregen opened this issue Nov 19, 2016 · 2 comments
Closed

Rebuild of core.a, even when none of its .o files have changed #193

PaulStoffregen opened this issue Nov 19, 2016 · 2 comments
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself
Milestone
1.3.23

Comments

@PaulStoffregen
Copy link

Long ago in Arduino 1.6.5, rebuilding core.a was skipped when all of its .o files were unchanged. This used to print in the verbose info:

Using previously compiled file: /tmp/build2611869353429022717.tmp/core.a

On Windows with slower disk drives, this made quite a noticeable speedup. Hopefully the builder can implement this someday?
@PaulStoffregen
Copy link
Author

PaulStoffregen commented Nov 19, 2016 •
edited
Loading

Here's the old Java code which used to perform this function:

https://github.com/arduino/Arduino/blob/1.6.5-r5/arduino-core/src/processing/app/debug/Compiler.java#L1064

The comments mention a corner case, which might be helpful to consider.

facchinm added a commit to facchinm/arduino-builder that referenced this issue Nov 21, 2016
@facchinm
Use previously compiled "core.a" if core files are unmodified
3cd5c35 
Solves arduino#193

Needs to add -MMD to .S.flags targets on all cores (otherwise the core gets recompiled everytime)

Signed-off-by: Martino Facchin <[email protected]>
@facchinm facchinm mentioned this issue Nov 21, 2016
Merged
@cmaglie
Copy link
Member

cmaglie commented Nov 23, 2016

Fixed by #194

@cmaglie cmaglie closed this as completed Nov 23, 2016
facchinm added a commit that referenced this issue Nov 29, 2016
@facchinm
Use previously compiled "core.a" if core files are unmodified
269fb70 
Solves #193

Needs to add -MMD to .S.flags targets on all cores (otherwise the core gets recompiled everytime)

Signed-off-by: Martino Facchin <[email protected]>
@cmaglie cmaglie added this to the 1.3.23 milestone Dec 19, 2016
@per1234 per1234 added conclusion: resolved Issue was resolved topic: code Related to content of the project itself labels Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself
Projects
None yet
Milestone
1.3.23
Development

No branches or pull requests
3 participants
@cmaglie @PaulStoffregen @per1234