Replace use of javax.xml.bind.DatatypeConverter #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DatatypeConverter was deprecated in Java 9 and has been removed in Java 11. Instead of DatatypeConverter#printHexBinary we use the equivalent method Hex#encodeHexString from the commons-codec library, which we already require anyway (see build.sh).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatatypeConverter was deprecated in Java 9 and has been removed in Java 11. Instead of DatatypeConverter#printHexBinary we use the equivalent method Hex#encodeHexString from the commons-codec library, which we already require anyway (see build.sh).
(My problem is, that I need to run Arduino IDE on Java 11 (or maybe 10), because otherwise the Serial Monitor won't work, and I need to run Arduino IDE on Java 8 (or maybe 9), to upload certificates via this plug-in. Since my change should make it work on all Java versions, I thought it would be a useful contribution.)