Many of our sketches would not load as they did not fit in memory regions - Also enabled DMA based SPI #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding I found that the majority of the sketches I would try would not load with the current default settings. Not sure how large they need to be, but this has worked for most of my sketches and I believe @mjs513 test sketches as well
These two configuration settings are needed to enable the SPI Async code to work in Zephyr on STM32 based boards.
|
I agree with @KurtE - with out the changes to the conf file for region sizes most of the sketches I tested would not run. |
… for PWM The code was already there, but before it checked that the index was valid it first checked if the pwm was ready, So moved the check up before that.
|
I pushed up the change that keeps analogWrite from faulting processor, if the passed in pin was not currently defined as Can move this to it's own PR if needed. |
|
Hi @KurtE , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: This may partially address #15 at least for the short term. Long term hopefully have more control
over this maybe on per sketch basis?
Not sure if this is the best approach, but I know that a lot of sketches that @mjs513 and I have been
experimenting with on Zephyr will not load do to not fitting into memory regions.
So did one commit that increased the size to the size that @mjs513 sent me, and it appears to works with
a lot more sketches.
I also had a second commit where I added two items conf file that enables Asynchronous SPI operations on
the giga.
I reran my simple ILI9341 test sketch which does fill screens of the display using a few methods, including this.