Skip to content

Use TX buffer for Wire slave writes #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2016

Conversation

sandeepmistry
Copy link
Contributor

Brings things inline with SAM core Wire lib. Also, allows for more consistent behaviour if the master requests more data than the slave writes.

The buffered TX data is:

  • sent one byte at a time on DRDY IRQ
  • cleared when master read mode is started/restarted
  • 0xff is sent if a read is triggered and the TX buffer is empty

@sandeepmistry sandeepmistry force-pushed the write-slave-tx-buffer branch from e0b1836 to e5166fb Compare June 17, 2016 13:56
@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b82_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request Use TX buffer for Wire slave writes #98
  5. Select one of the boards under SAMD Pull Request Use TX buffer for Wire slave writes #98 in Tools->Board menu
  6. Compile/Upload as usual

@agdl agdl merged commit 2f0f349 into arduino:master Jul 8, 2016
@sandeepmistry sandeepmistry deleted the write-slave-tx-buffer branch July 8, 2016 15:00
@cmaglie cmaglie added this to the Release 1.6.19 milestone Jul 11, 2018
boseji pushed a commit to go-ut/combined-ArduinoCore-samd that referenced this pull request May 30, 2020
Comment out the initialization of all SAMD21 pins to INPUT to allow them to remain tri-stated by default.   

See adafruit/Adafruit_SleepyDog#17 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants