Fix async serial port operation at 1200 baud, fix flush, fix data bits. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_Datasheet–09/2015, constant in formula should be 65536, not 65535. Also add 0.5 to round correctly to closest integer.
TomKeddie
changed the title
TomKeddie
changed the title
|
@TomKeddie thanks for submitting! The changes look good. I've proposed #86 as an alternative to TomKeddie@103ddee. It changes UART configuration to use asynchronous fractional mode. |
|
@sandeepmistry I think #86 is better. Having floating point code in the base libraries should be avoided wherever possible. You should commit and then I will pull and clean up my change. |
|
@TomKeddie Alternatively I can cherry pick the reminder of this PR, just tell me. |
|
@cmaglie if you have the time to cherry pick I'd appreciate it. Thanks, Tom |
|
rebased and merged. Thanks! |
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #84 operation at 1200 baud.
Fix #83 for data widths other than 8 bits.
Fix #82 to make flush semantics match AVR.