Skip to content

SafeRingBuffer.h: Prevent compiler warning about reaching end of non-void function (see #580) #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021
Merged

SafeRingBuffer.h: Prevent compiler warning about reaching end of non-void function (see #580) #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cores/arduino/SafeRingBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ int SafeRingBufferN<N>::read_char() {
synchronized {
return RingBufferN<N>::read_char();
}

// We should never reached this line because the synchronized {} block gets
// executed at least once. However the compiler gets confused and prints a
// warning about control reaching the end of a non-void function. This
// silences that warning.
return -1;
}

template <int N>
Expand All @@ -53,4 +59,4 @@ void SafeRingBufferN<N>::store_char(uint8_t c) {
}

#endif /* _SAFE_RING_BUFFER_ */
#endif /* __cplusplus */
#endif /* __cplusplus */