Correct I2C frequency calculation formula #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow variant to override the default rise time in nanoseconds via define
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
|
Hi @martinl1, @Adminius, @deladriere, Could you please try out these changes and see if it addresses the discussion in issue #259. The rise time is based on the 4.7K pull up resistors all the Arduino.cc SAMD boards. Other variants can override the default value if needed. |
|
These changes were tested with a MKR Zero and MKR WAN1300, using a OLED display and ECC508 over the I2C bus. A Saleae logic analyzer was used to observe traffic on the I2C bus. |
boseji
pushed a commit
to go-ut/combined-ArduinoCore-samd
that referenced
this pull request
May 12, 2021
Fixes arduino#287 The warnings look like: ``` Line 338 Char 37 warning: 'void* memcpy(void*, const void*, size_t)' writing to an object of type 'struct DmacDescriptor' with no trivial copy-assignment [-Wclass-memaccess] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #259.
Also alllow variant to override the default rise time in nanoseconds via define.