Some updates on Stream and Print class. #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,6 +57,10 @@ class Print | |||
| return write((const uint8_t *)buffer, size); | |||
| } | |||
|
|
|||
| // default to zero, meaning "a single write may block" | |||
| // should be overriden by subclasses with buffering | |||
| virtual int availableForWrite() { return 0; } | |||
There was a problem hiding this comment.
Should we make Uart:: availableForWrite() virtual as well?
There was a problem hiding this comment.
Same for I2S, those are the only two spots in the repo.
There was a problem hiding this comment.
Based on testing, adding the virtual doesn't seem to make a difference, we just needed to change the size_t to int in I2S.
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
sandeepmistry
approved these changes
Aug 23, 2017
This was referenced Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.