Skip to content

Correct SerialUSB return value #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2016

Conversation

sandeepmistry
Copy link
Contributor

Resolves #138.

As mentioned in #138 SerialUSB.write would always return zero, this corrects the return value to return the number of bytes written.

@ArduinoBot
Copy link

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/samd/package_samd-b79_index.json

ℹ️ To test this build:

  1. Open the Preferences of the Arduino IDE.
  2. Add the Build URL above in the Additional Boards Manager URLs field, and click OK.
  3. Open the Boards Manager (menu Tools->Board->Board Manager...)
  4. Install Arduino SAMD core - Pull Request Correct SerialUSB return value #143
  5. Select one of the boards under SAMD Pull Request Correct SerialUSB return value #143 in Tools->Board menu
  6. Compile/Upload as usual

@agdl agdl merged commit f3a29a7 into arduino:master Jun 6, 2016
@cmaglie cmaglie added this to the Release 1.6.7 milestone Jun 17, 2016
@sandeepmistry sandeepmistry deleted the cdc-write-return-value branch July 8, 2016 15:00
boseji pushed a commit to go-ut/combined-ArduinoCore-samd that referenced this pull request May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants