Skip to content

Regression in UART buffer size #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sandeepmistry opened this issue Oct 15, 2021 · 0 comments · Fixed by #651
Closed

Regression in UART buffer size #650

sandeepmistry opened this issue Oct 15, 2021 · 0 comments · Fixed by #651

Comments

@sandeepmistry
Copy link
Contributor

In the v1.8.9 release of the core the default ring buffer size was set to 256: https://github.com/arduino/ArduinoCore-samd/blob/1.8.9/cores/arduino/RingBuffer.h#L26-L32

After #560 was merged it looks like this is reduced to 64 bytes now as api/RingBuffer.h is used instead of RingBuffer.h in cores/arduino/SafeRingBuffer.h: https://github.com/arduino/ArduinoCore-API/blob/master/api/RingBuffer.h#L33

This might also be related to #644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UART: restore default buffer size to 256 bytes facchinm/ArduinoCore-samd
1 participant
@sandeepmistry