-
-
Notifications
You must be signed in to change notification settings - Fork 725
AceTime example compilation is breaking checks #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
stonehippo opened this issue
Feb 22, 2021
· 4 comments
· Fixed by #607 or arduino/ArduinoCore-API#144
Closed
AceTime example compilation is breaking checks #606
stonehippo opened this issue
Feb 22, 2021
· 4 comments
· Fixed by #607 or arduino/ArduinoCore-API#144
Comments
Just echoing this observation to elevate. This issue has a high severity, because the entire repository has ground to a halt. |
Closed
Bueller? Bueller? ;-) |
facchinm
added a commit
to facchinm/ArduinoCore-API
that referenced
this issue
Mar 29, 2021
facchinm
added a commit
to facchinm/AceTime
that referenced
this issue
Mar 29, 2021
@per1234 I'd proceed by merging #607 (to fix the CI at least), then if we get some feedback for the patch series ( arduino/ArduinoCore-API#144 and friends) we can revert it. |
@facchinm I agree that's the best approach. |
facchinm
added a commit
to facchinm/ArduinoCore-API
that referenced
this issue
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Several of the most recent PRs are reporting broken checks. I took a look and it's not the code in the PR that's failing but the compilation of the AceTime examples. It seems that there's a error with the SAMD support in that library. From one of the check logs:
This appears in all of the Compile Examples logs for PR #605, for example.
According to the AceTime/AceCommon maintainer, they're blacklisting ArduinoCore-samd for versions >=1.18.10 (see bxparks/AceTime#45 and bxparks/AceCommon#9). It seems like the best course of action is to remove AceTime from the checks for the time being.
The text was updated successfully, but these errors were encountered: