Skip to content

Programming port UART doesn't work at 230400; no rounding in BRGR calculations. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
WestfW opened this issue Aug 2, 2018 · 1 comment
Open

Programming port UART doesn't work at 230400; no rounding in BRGR calculations. #54

WestfW opened this issue Aug 2, 2018 · 1 comment

Comments

@WestfW
Copy link
Contributor

WestfW commented Aug 2, 2018

The Baud Rate Generator Divisor calculations in UARTClass::init() do not round, leading to error rates higher than they could be. In particular, the error at 230400bps is both large and in the opposite direction of the 16u2 error, and it fails. Adding rounding allows it to work.
@WestfW
Copy link
Contributor Author

WestfW commented Aug 2, 2018

#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WestfW