Define digital pins via static const instead of #define

[mjs513]

@aentinger
Sorry for the delay in getting this to you. Got side tracked with a weird issue as I was trying to get the Encoder library updated so people can use with the R4 boards. But in accordance with your request for me to submit a PR for [ArduinoEigen] Pin Definitions Conflict with Sketch/Library Variables when used with ArduinoCore-renesas Issue #50 this is the update. As I mentioned "constexpr" throws a error so I left it as const like the analog pins. Out of curiosity what version of c++ are the R4 using?

regards
Mike

[CLAassistant]

All committers have signed the CLA.

[aentinger]

Out of curiosity what version of c++ are the R4 using?

C++17, see here.

Consequently constexpr should not be a problem.

Mind updating the PR accordingly?, i.e. constexpr uint8_t D0 = PIN_D0;.

[mjs513]

@aentinger - done. Faster turn time than yesterday. But if I try to compile this example on the minima:

void setup() {
  Serial.begin(115200);
  while(!Serial && millis() < 5000) {}
  int D0 = 1;
  Serial.println(D0);
  //digitalWrite(D0, HIGH);
}

void loop() {}

I will get this error using constexpr:

C:\Users\Merli\AppData\Local\Arduino15\packages\arduino\hardware\renesas_uno\1.0.2\variants\MINIMA/pins_arduino.h:75:8: error: unknown type name 'constexpr'
 static constexpr uint8_t D0 = PIN_D0;
        ^~~~~~~~~
C:\Users\Merli\AppData\Local\Arduino15\packages\arduino\hardware\renesas_uno\1.0.2\variants\MINIMA/pins_arduino.h:75:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'D0'
 static constexpr uint8_t D0 = PIN_D0;

[aentinger]

Well, I get a lot of errors, but none like you ... 🤔

/home/alex/Arduino/hardware/arduino-git/renesas/variants/UNOWIFIR4/pins_arduino.h:54:31: error: 'PIN_D0' was not declared in this scope
 static constexpr uint8_t D0 = PIN_D0;
                               ^~~~~~
/home/alex/Arduino/hardware/arduino-git/renesas/variants/UNOWIFIR4/pins_arduino.h:54:31: note: suggested alternative: 'PIN_A0'
 static constexpr uint8_t D0 = PIN_D0;
                               ^~~~~~
                               PIN_A0
/home/alex/Arduino/hardware/arduino-git/renesas/variants/UNOWIFIR4/pins_arduino.h:55:31: error: 'PIN_D1' was not declared in this scope
 static constexpr uint8_t D1 = PIN_D1;
                               ^~~~~~

[mjs513]

oops - darn copy and paste error. Just pushed the fix to clear up the errors you are seeing.

[aentinger]

I suppose you'll also need to extend support for Portenta C33?

[mjs513]

Not home right now but will do later today. Still saw the error in build fails?

…

On Tue, Jul 18, 2023 at 10:18 AM Alexander Entinger < ***@***.***> wrote: I suppose you'll also need to extend support for Portenta C33? — Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABI6DROS6NOCT6JPBCG5723XQ2LMZANCNFSM6AAAAAA2OGBNBQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mjs513]

Ok - updated.

[aentinger]

It seems the problem is that Arduino.h and by extension pins_arduino.h produce an error when included into a C file, i.e. cortex_handlers.c in this case.

Try renaming cortex_handlers.c to .cpp and prefix Stacktrace_Handler with extern "C":

-void Stacktrace_Handler(void) {
+extern "C" void Stacktrace_Handler(void) {

[aentinger]

I've reconsidered, drop constexpr and let's go with const as you've proposed since it will provide broader compatibility.

[mjs513]

@aentinger
Revert back to const . And Welcome back.

[facchinm]

Merged, thank you!