-
-
Notifications
You must be signed in to change notification settings - Fork 86
Adding WiFiS3 API documentation #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add API docs workflow
…cumentation Adding API documentation for the WiFiS3 library
|
@BenjaminDannegard what is the status of this PR? |
I am trying to fix the issues so that we can merge |
@BenjaminDannegard I suggest you remove the |
@BenjaminDannegard ci is failing for reasons not relates to this PR, so you don't have to worrie about the ❌ for C33 You need to sign the CLA to get this PR merged |
@pennam I have signed it now, but it is still showing that "❌ actions-user" has not signed. Not sure what this means |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have submitted a pull request to the "arduino/render-docs-github-action" action that generated the commit by "actions-user" to attribute commits to a more appropriate entity, which will not fail the CLA check:
arduino/render-docs-github-action#1
My recommendation is that the failing CLA check not be treated as a blocker for merging the pull request. The repository admins can bypass the required check to merge the PR.
If arduino/render-docs-github-action#1 is rejected then we can set up a CLA exemption for the "actions-user" account to avoid CLA check failures for future PRs that contain commits generated by the "arduino/render-docs-github-action" action.
@per1234 You're admin of this repo. Can you please merge the PR? |
@sebromero I would only feel comfortable merging this after I had done a comprehensive review. I am not very knowledgeable in this code base so I'm not well equipped to perform such a review. |
Added documentation for the WiFiS3 library to the library files and added a API.h file