Allow FreeRTOS hook for C33 only and improve its reliability

[facchinm]

Fixes concerns from #369 (comment)

@pennam @hexnet1234 @gpb01

[gpb01]

@facchinm: Perhaps it would be better to condition, with the same #ifdef, also the code within port.c so as to have it compiled only if it is really useful. This, for those who use in IDE a "Compiler warning" level higher than the minimum, could avoid a series of unnecessary warnings during compilation for UNO R4. :-)

Cordially,

Guglielmo

[hexnet1234]

I agree with @gpb01.

If I remember correctly, the built-in compiler of the Arduino IDE does strip unused functions out of the binary,
but adding this check seems like a good idea. Just to get rid of warnings, and (very slightly) improve compile time.
Compile-time improvements like this are small on their own, but do add up eventually.

Best regards
hexnet1234

[gpb01]

If I remember correctly, the built-in compiler of the Arduino IDE does strip unused functions out of the binary

Yes, correct!

Just to get rid of warnings,

The compiler gives the following warning:

/Users/gpb01/Desktop/Arduino Portable 1.3.1.app/Contents/Java/portable/packages/arduino/hardware/renesas_uno/1.3.1/libraries/Arduino_FreeRTOS/src/portable/FSP/port.c: In function 'loop_thread_func':
/Users/gpb01/Desktop/Arduino Portable 1.3.1.app/Contents/Java/portable/packages/arduino/hardware/renesas_uno/1.3.1/libraries/Arduino_FreeRTOS/src/portable/FSP/port.c:238:9: warning: implicit declaration of function 'loop'; did you mean 'bool'? [-Wimplicit-function-declaration]
         loop();
         ^~~~
         bool

... and, since it is very easy to remove it, why not do it? :-)

Guglielmo

[facchinm]

Done in b83fd20 , if the CI turns green I'm going to merge @pennam

[gpb01]

@facchinm: Thanks! :-)

Guglielmo

[hexnet1234]

Looks good 👍

Best regards
hexnet1234

[Wetmelon]

I get a warning for loop() now on C33 1.3.2 and an error if I don't define it for the idle task, is that intended?

[facchinm]

@Wetmelon having loop() implemented is compulsory in every Arduino sketch so I don't think it can be called a bug 🙂 About the warning, we'll fix it in the next core release