Skip to content

Core renesas / Storage library, Fix for #366 (Name conflict in library Storage) #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2024
Merged

Core renesas / Storage library, Fix for #366 (Name conflict in library Storage) #370

merged 4 commits into from
Oct 3, 2024

Conversation

maidnl
Copy link
Contributor

@maidnl maidnl commented Aug 28, 2024

Renamed storage debug function to avoid clash with user code

@maidnl maidnl requested a review from pennam August 28, 2024 15:11
@per1234 per1234 added the topic: code Related to content of the project itself label Aug 28, 2024
@per1234 per1234 linked an issue Aug 28, 2024 that may be closed by this pull request
Name conflict in library Storage #366
Closed
@facchinm facchinm self-requested a review August 29, 2024 07:23
facchinm
facchinm requested changes Aug 29, 2024
View reviewed changes
pennam
pennam requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maidnl you missed to change this line

ArduinoCore-renesas/libraries/Storage/storage_common.h

Line 101 in 0281be5

debug("ASSERT FAILED at line %d in file %s",__LINE__,__FILE__); }} while(0)

@pennam pennam self-requested a review October 3, 2024 07:22
pennam
pennam approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pennam pennam requested a review from facchinm October 3, 2024 07:23
@pennam pennam merged commit 1712cb4 into arduino:main Oct 3, 2024
7 checks passed
andreagilardoni pushed a commit to andreagilardoni/ArduinoCore-renesas that referenced this pull request Nov 14, 2024
@maidnl @andreagilardoni
Core renesas / Storage library, Fix for arduino#366 (Name conflict in…
942a19c 
… library Storage) (arduino#370)

* renaming storage debug function to avoid clash with user code
andreagilardoni pushed a commit to andreagilardoni/ArduinoCore-renesas that referenced this pull request Nov 19, 2024
@maidnl @andreagilardoni
Core renesas / Storage library, Fix for arduino#366 (Name conflict in…
74d598e 
… library Storage) (arduino#370)

* renaming storage debug function to avoid clash with user code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm approved these changes

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name conflict in library Storage
4 participants
@maidnl @facchinm @pennam @per1234