Skip to content

True 16 bit transfer, and new loop friendly 16 bit transfer #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

True 16 bit transfer, and new loop friendly 16 bit transfer #362

wants to merge 1 commit into from

Conversation

drmcnelson
Copy link

This replaces the transfer16() with a true 16 bit transfer, adds a new loop friendly 16 bit transfer, and rename the old transfer16() as two bytes to transfer16_asbytes()

This replaces the transfer16() with a true 16 bit transfer, adds a new loop friendly 16 bit transfer, and rename the old transfer16() as two bytes to transfer16_asbytes()
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit a pull request @drmcnelson.

Arduino has a strict policy that we can only accept pull requests after the contributor has signed the contributor license agreement. Since you have stated in #363 that you refuse to sign the agreement, we can not accept this pull request.

@per1234 per1234 closed this Aug 18, 2024
@per1234 per1234 self-assigned this Aug 18, 2024
@per1234 per1234 added type: enhancement Proposed improvement conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself labels Aug 18, 2024
@drmcnelson
Copy link
Author

In fact I did sign the CLA, I filled in the form, ticked the box and clicked the button.

Your software after that asked for access to my private data. When a bot asks for access to private data, that is where I draw the line, as any normal person should.

I plan to keep the fork up, or at least the patched SPI support with the functioning and improved 16 bit transfers. It seems there are people who want it.

Or, you could incorporate into the main tree yourself, you certainly have my permission to do that. Just let me know if you do.

@drmcnelson

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants