Skip to content

Fix RTC resetting after reboot #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 7, 2024
Merged

Fix RTC resetting after reboot #347

merged 7 commits into from
Aug 7, 2024

Conversation

andreagilardoni
Copy link
Contributor

This PR aims to fix the issue described here #181.
The issue can be described as follow: When the board is reset, or powered off with VRTC powered, the RTC time value is reset.

@alranel alranel mentioned this pull request Jul 8, 2024
Closed
@andreagilardoni andreagilardoni force-pushed the rtc-fixes branch 3 times, most recently from 4203dbe to da4ac83 Compare July 10, 2024 12:12
@andreagilardoni andreagilardoni marked this pull request as ready for review July 10, 2024 12:12
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Jul 12, 2024
@workgroupengineering
Copy link

Hi, is there an ETA of when this PR will be merged and published?

@andreagilardoni
Copy link
Contributor Author

Hi @workgroupengineering, since this PR required the FSP core to be recompiled, we are testing this to check whether we have any issues on other components. If you want you can apply this patch on your local core and report to us if you find any issues.

@workgroupengineering
Copy link

Thanks for the reply, I'll try

@pennam
Copy link
Contributor

pennam commented Aug 5, 2024

Portenta C33 + USB cable plugged -> reset button 👍
Portenta C33 + Portenta breakout + CR2032 + USB cable -> reset button 👍
Portenta C33 + Portenta breakout + CR2032 + USB cable -> disconnect usb cable 👍

@pennam
Copy link
Contributor

pennam commented Aug 7, 2024

Portenta C33 retest after force push 👍
UNO R4 Minima + USB cable plugged -> reset button 👍 Thanks @aentinger
UNO R4 WiFi + USB cable plugged -> reset button 👍
UNO R4 WiFi + USB cable plugged + external Vbat -> reset button 👍
UNO R4 WiFi + USB cable plugged + external Vbat -> disconnect usb cable 👍

@pennam pennam self-requested a review August 7, 2024 13:19
pennam
pennam approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@pennam pennam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@andreagilardoni andreagilardoni merged commit 731b943 into arduino:main Aug 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pennam pennam pennam approved these changes

Assignees
No one assigned
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreagilardoni @workgroupengineering @pennam @per1234