Skip to content

fixing millis rollover bug x2 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2023
Merged

fixing millis rollover bug x2 #196

merged 4 commits into from
Nov 29, 2023

Conversation

delta-G
Copy link
Contributor

@delta-G delta-G commented Nov 27, 2023

Fix TwoWire::read_from and TwoWire::write_to to use proper millis code that can handle rollover.
Fixes issue #195

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Nov 27, 2023
@per1234 per1234 linked an issue Nov 28, 2023 that may be closed by this pull request
TwoWire::read_from and TwoWire::write_to millis rollover bug #195
Closed
aentinger
aentinger reviewed Nov 28, 2023
View reviewed changes
aentinger
aentinger suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 However, please use either "underscore case" start_millis or drop the millis suffix, since all other variables here seem to be non CamelCase.

delta-G and others added 2 commits November 28, 2023 14:24
@delta-G @aentinger
Update libraries/Wire/Wire.cpp
d118e9c 
const correct

Co-authored-by: Alexander Entinger <[email protected]>
@delta-G
Fixes arduino#195
8944a64 
Fixes arduino#195
Includes review from @aentinger
@delta-G delta-G requested a review from aentinger November 28, 2023 22:12
@delta-G
Copy link
Contributor Author

delta-G commented Nov 28, 2023

I just changed the name to start as suggested. It looks like everything compiles now. Please let me know if it needs anything else.

Thanks!

aentinger
aentinger approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger aentinger merged commit c0f158f into arduino:main Nov 29, 2023
@delta-G delta-G deleted the DG_WireMillis branch May 6, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TwoWire::read_from and TwoWire::write_to millis rollover bug
4 participants
@delta-G @CLAassistant @aentinger @per1234