-
-
Notifications
You must be signed in to change notification settings - Fork 86
Ethernet driver and LWIP wrapper fixes #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c7890a3
to
4896ed2
Compare
This fix breaks Wifi on C33. This fix works well with ethernet, that can leverage lwip buffer, but breaks wifi, because it uses its own queue inside of the driver. The wifi driver should be changed and made similar to the ethernet driver and mimic its behaviour. |
After some testing i discovered the following:
Drivers still need improvements, and further fine tuning of lwip library are required in order to work properly with bigger files. Performance needs improvement, since at the application layer we use only the <10% of the bandwidth used at the driver level. This is probably related to:
The following is an example of output from an http File download of arbitrary size.
Using the following ping command we can test the board with a sketch that initializes Ethernet.
Here we can see that the Driver is able to handle that packets and reach a throughput of 8592.56KB/s (67Mbit/s), and the the driver with lwip is able to handle the packets.
|
This fix aims to solve issues on ethernet on portenta c33. This required some changes in the structure of the library, in order to avoid wasting memory on temporary queues.
3f2e6d1
to
5f4707f
Compare
5f4707f
to
23eccce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested with Cloud Sketches both WiFi and Ethernet works.
👍 Fixed file download with ethernet (no TLS)
This PR aims to fix the issues that made ethernet drivers unrealiable and unable to process complex data transfers, like file downloads. This should improve stability on all drivers using lwip wrapper.
Further improvements can be made in order to have better performances and stability, but they require a deeper knowledge of renesas fsp mechanism for RX zero copy