WiFiS3 client connect timeout #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: enhancement
JAndrassy
force-pushed
the
wifis3_client_con_timeout
branch
from
8ce37f0 to
bd2c159
Compare
|
PR in firmware is merged but checks still fail because extras/uno-r4-wifi-usb-bridge links to release 0.3.0 tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding PR in firmware is arduino/uno-r4-wifi-usb-bridge#23
If connect timeout is not set on client, the library will use CONNECT commands which exist in older versions of the firmware.
There is no need to use extra command to connect with IP address. The connect with hostname uses hostByName which first attempts to convert the string to IP address. So to avoid duplicate code, this PR redirects connect with IP to connect with hostname.
The Modem bug fix PR #147 is need to see the effect of the timeout.
the checks will fail while the PR in firmware is not merged
overview of Client API in Arduino networking libraries:
https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#client-getters-and-setters