Skip to content

The SDU library for Uno R4 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

The SDU library for Uno R4 #119

merged 1 commit into from
Sep 4, 2023

Conversation

JAndrassy
Copy link
Contributor

@JAndrassy JAndrassy commented Sep 2, 2023

I ported the SDU library from SAMD core to Renesas core for Uno R4. It is useful with my ArduinoOTA library, which already supports OTA update from IDE to Uno R4 using InternalStorage and with the SDU library SDStorage can be used too.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 3, 2023
per1234
per1234 previously requested changes Sep 3, 2023
@JAndrassy JAndrassy force-pushed the sdu branch 2 times, most recently from 0cfceb6 to e9f6f0b Compare September 3, 2023 08:29
@per1234 per1234 dismissed their stale review September 3, 2023 20:13

Requested changes have been made. Thanks!

@aentinger
Copy link
Contributor

Hi @pennam ☕ 👋

I just want to check with you, if the extension of the linker file as done in this PR (i.e. here) is problematic in terms of our own OTA workflow?

@aentinger
Copy link
Contributor

Also there are some examples failing in the CI build, @JAndrassy can you please take a look?

@JAndrassy
Copy link
Contributor Author

JAndrassy commented Sep 4, 2023

@aentinger

the check fails because the repo is inconsistent. it is not a problem with this PR

there is no overlap with OTA functionality for IoT Cloud

@aentinger
Copy link
Contributor

@aentinger the check fails because CI attempts to compile C33 library for Uno R4. it is a problem of the CI

In this case the CI workflow needs to be adjusted to compile those examples only for the R4.

@JAndrassy
Copy link
Contributor Author

JAndrassy commented Sep 4, 2023

the CI fail is not related to this PR
it is in /libraries/OTAUpdate/examples/WiFiFirmwareOTA

@aentinger
Copy link
Contributor

True enough, I've opened #121 to have this fixed. CI failure in main is ... undesirable.

@aentinger aentinger merged commit 700ab05 into arduino:main Sep 4, 2023
@JAndrassy JAndrassy deleted the sdu branch September 15, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants