Skip to content
This repository was archived by the owner on Apr 16, 2021. It is now read-only.

analogWrite() range should be 0-255, not 0-256. #75

Merged
merged 1 commit into from
May 29, 2020
Merged

analogWrite() range should be 0-255, not 0-256. #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cores/arduino/wiring_analog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ static mbed::PwmOut* PinNameToPwmObj(PinName P) {

void analogWrite(PinName pin, int val)
{
float percent = (float)val/(float)(1 << write_resolution);
float percent = (float)val/(float)((1 << write_resolution)-1);
#ifdef digitalPinToPwmObj
mbed::PwmOut* pwm = PinNameToPwmObj(pin);
if (pwm == NULL) {
Expand All @@ -57,7 +57,7 @@ void analogWrite(PinName pin, int val)

void analogWrite(pin_size_t pin, int val)
{
float percent = (float)val/(float)(1 << write_resolution);
float percent = (float)val/(float)((1 << write_resolution)-1);
#ifdef digitalPinToPwmObj
mbed::PwmOut* pwm = digitalPinToPwmObj(pin);
if (pwm == NULL) {
Expand Down Expand Up @@ -95,4 +95,4 @@ int analogRead(pin_size_t pin)
void analogReadResolution(int bits)
{
read_resolution = bits;
}
}