Use authenticated API requests in "Compile Examples" CI workflow #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arduino/compile-sketches GitHub Actions action used in the "Compile Examples" workflow queries the GitHub API for the base ref of the pull request, which is used for the memory deltas determination. There were a couple workflow runs recently (1, 2) that failed due to rate limiting. Authenticated API requests are given a more generous API request allowance, so providing the action with the automatically generated GitHub access token should prevent this from happening again.
per1234
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
The CI failure:
https://github.com/arduino/ArduinoCore-megaavr/pull/97/checks?check_run_id=1885261839#step:8:20954
/github/home/.arduino15/packages/arduino/tools/avr-gcc/7.3.0-atmel3.6.1-arduino5/bin/avr-size -A /tmp/arduino-sketch-B5105B2618A854F21756DC5FA3022BBE/Tweeter.ino.elf
Sketch uses 65852 bytes (135%) of program storage space. Maximum is 48640 bytes.
Global variables use 2639 bytes (42%) of dynamic memory, leaving 3505 bytes for local variables. Maximum is 6144 bytes.
Sketch too big; see http://www.arduino.cc/en/Guide/Troubleshooting#size for tips on reducing it.
Error during build: text section exceeds available space in board
will require action (it's while compiling this sketch: https://github.com/arduino-libraries/Arduino_OAuth/tree/master/examples/Tweeter), but is unrelated to the changes proposed in this PR.
|
Memory usage change @ 829a0c6
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arduino/compile-sketches GitHub Actions action used in the "Compile Examples" workflow queries the GitHub API for the base ref of the pull request, which is used for the memory deltas determination.
There were a couple workflow runs recently (1, 2) that failed due to rate limiting. Authenticated API requests are given a more generous API request allowance, so providing the action with the automatically generated GitHub access token should prevent this from happening again.