-
-
Notifications
You must be signed in to change notification settings - Fork 64
Bugfix: wrong default I2C baud rate was set for Arduino Nano Every #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ afb0266
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #88.
Whenever the default baud rate was used, or a custom frequency being less than 800kHz or greater than 1,200kHz was set, the computed baud rate was incorrect due to an integer overflow.
F_CPU_CORRECTED
is auint32_t
set to 16000000 for Arduino Nano Every. It gets multiplied byt_rise
which is set to 1000, thus it overflows the numeric range for auint32_t
.When using the default baud rate,
TWI0.MBAUD
was set to 73 instead of 67 which appears to be the right value.(How can we add a unit test for this?)