Remove PROGMEM attributes and pgm_read_byte #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not needed since the megaAVR 0-series have a unified address space. Using pgm_read* will only increase memory usage
|
Manually merged with a small fix on https://github.com/arduino/ArduinoCore-megaavr/pull/55/files#diff-be0c0cc05a23bed9071a3a0ea0ec2822R277 . |
|
You're welcome!
Did I sneak in a bug or typo? looked through the latest commit, but couldn't really find anything different from my commit... |
|
It was missing a pgm_read_byte removal on the linked macro 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not needed since the megaAVR-0 series have unified memory. Content is kept in progmem as long as they are defined
const. Will close #11.