Skip to content

nicla: Add missing return value in enterShipMode function. #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

nicla: Add missing return value in enterShipMode function. #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/Nicla_System/src/BQ25120A.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class BQ25120A
BQ25120A() {};

uint8_t getStatus();
void writeByte(uint8_t address, uint8_t subAddress, uint8_t data);
bool writeByte(uint8_t address, uint8_t subAddress, uint8_t data);
uint8_t readByte(uint8_t address, uint8_t subAddress);

};
Expand Down
2 changes: 1 addition & 1 deletion libraries/Nicla_System/src/Nicla_System.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ bool nicla::enterShipMode()

uint8_t status_reg = _pmic.getStatus();
status_reg |= 0x20;
_pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_STATUS, status_reg);
return _pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_STATUS, status_reg);
}

uint8_t nicla::readLDOreg()
Expand Down
5 changes: 3 additions & 2 deletions libraries/Nicla_System/src/pmic_driver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@ uint8_t BQ25120A::getStatus()
return c;
}

void BQ25120A::writeByte(uint8_t address, uint8_t subAddress, uint8_t data)
bool BQ25120A::writeByte(uint8_t address, uint8_t subAddress, uint8_t data)
{
cd = 1;
nicla::i2c_mutex.lock();
Wire1.beginTransmission(address);
Wire1.write(subAddress);
Wire1.write(data);
Wire1.endTransmission();
uint8_t result = Wire1.endTransmission();
nicla::i2c_mutex.unlock();
cd = 0;
return result == 0;
}

uint8_t BQ25120A::readByte(uint8_t address, uint8_t subAddress)
Expand Down