-
-
Notifications
You must be signed in to change notification settings - Fork 212
PR: update camera.cpp for the PortentaM4 Core #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 1c3150f
Click for full report table
Click for full report CSV
|
facchinm
requested changes
Jun 27, 2022
Memory usage change @ 89f7ab0
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this issue Feature Request: PortentaH7 Camera working using M4 #504 and great suggestions from @facchinm I managed to get the Portenta M4 Camera working by making a few changes to the camera.cpp file. Specifcally adding 4 sets of
The only hack I am a bit concerned about is here where I excluded the following function using an
#ifndef
Not really sure if excluding the
SCB_InvalidateDCache_by_Addr
is the best solution for the M4 core.I have tested the PR on both an OLED program and an edgeImpulse 64x64 FOMO Vision program as well as the standard CameraMotionDetect (flashes blue LED on motion.)