-
-
Notifications
You must be signed in to change notification settings - Fork 212
Improve readme and add flag to turn debug info ON for libmbed #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@per1234 if you could give a grammar/quality check it would be great ❤️ |
Looks to me like @per1234 already had a field day. I'll wait with my review until his suggestions have been resolved. One thing I can say already is that if the intention is to provide information on how to create a debuggable build the text would need to be restructured a bit, like having a headline: "How to enable debugging for ArduinoCore-mbed based boards". I felt that although I personally know what to look for it was not that easy for me to extract that information. |
Co-authored-by: per1234 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now from a nitpick standpoint. I don't have time now to evaluate in detail it from a technical standpoint, but I think this is a very nice enhancement over the previous documentation and script.
Thanks Martino!
…urce-code-level-debugging.
That's my take on improving the issue I mentioned above. What do you guys think? |
Looks good to me. |
@aentinger thanks for the patch, it was much needed! I pushed another commit to explain how to change the project config file, hope it's clear enough |
People arriving at the README can then follow the bread-crumbs to the more comprehensive documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too
No description provided.