Fix library.properties for bundled libraries #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 2d1854b
Click for full report table
Click for full report CSV |
Still only 7.11 compatible
facchinm
force-pushed
the
add_library_properties
branch
from
2d1854b to
dd740f4
Compare
|
Memory usage change @ dd740f4
Click for full report table
Click for full report CSV |
facchinm
force-pushed
the
add_library_properties
branch
from
dd740f4 to
4424b33
Compare
|
Memory usage change @ 4424b33
Click for full report table
Click for full report CSV |
per1234
reviewed
Oct 8, 2021
| @@ -0,0 +1,9 @@ | |||
| name=Nano33BLE_System | |||
There was a problem hiding this comment.
This tutorial will need to be updated to account for the "Nano33_System" -> "Nano33BLE_System" name change:
https://docs.arduino.cc/tutorials/nano-33-ble-sense/getting-started-omv#updating-the-bootloader
CC: @sebromero
per1234
suggested changes
Oct 8, 2021
There was a problem hiding this comment.
I have also submitted a PR to this branch for the necessary changes to the CI system:
facchinm#1
libraries/Portenta_SDRAM/examples/SDRAM_operations/SDRAM_operations.ino
Outdated
Show resolved
Hide resolved
libraries/USBMSD/examples/AccessFlashAsUSBDisk/AccessFlashAsUSBDisk.ino
Outdated
Show resolved
Hide resolved
libraries/USBMSD/examples/AccessFlashAsUSBDisk/AccessFlashAsUSBDisk.ino
Outdated
Show resolved
Hide resolved
libraries/Portenta_SDRAM/examples/SDRAM_operations/SDRAM_operations.ino
Outdated
Show resolved
Hide resolved
Co-authored-by: per1234 <[email protected]>
|
Memory usage change @ f3de8b0
Click for full report table
Click for full report CSV |
A new example sketch ("ArduinoLogo") was added to the "Portenta_Video" library. This sketch has a dependency on the
"lvgl" library, so it must be installed by the "smoke test" sketch compilation CI workflow to avoid a spurious
compilation failure.
Previously, some of the bundled libraries did not provide example sketches, meaning there was no way to run a "smoke test" on them via the sketch compilation CI workflow. Now that examples have been added for these libraries, it is possible to get a basic check that the code compiles.
facchinm
force-pushed
the
add_library_properties
branch
from
ee41f02 to
0ebf94f
Compare
|
Memory usage change @ 0ebf94f
Click for full report table
Click for full report CSV |
|
@facchinm I think the CI failure was a transient network outage. I'm seeing a lot of intermittent problems across various random workflow runs over the last couple hours. It might pass if you try rerunning the workflow. |
per1234
reviewed
Oct 13, 2021
| - libraries/Portenta_Video | ||
| - libraries/RPC | ||
| - board: | ||
| fqbn: arduino:mbed:envie_m7 | ||
| additional-libraries: | | ||
| - name: lvgl | ||
| version: 7.11.0 |
There was a problem hiding this comment.
At the time I made the suggestion to add this, the code was not compatible with 8.x, so I pinned to the last of the 7.x series. It looks like that limitation has since been lifted. The pin isn't necessary for the sake of the workflow or action so you are free to configure it as you like. I see it was already unpinned for the arduino:mbed:envie_m4 compilations.
There was a problem hiding this comment.
👍 , I'd leave one on 7.11 and one on 8.0.2 to make sure it still compiles in both 😉
This was referenced Oct 28, 2021
Warning on Raspberry pi pico but sketch is recommended by arduino IDE
arduino-libraries/Scheduler#12
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDE 2.0 requires non-legacy libraries to properly display the embedded examples.
Lot of them were shipping outdated/unfinished examples, some others were not shipping any, so this PR also contains an overall cleanup.
@per1234 @ubidefeo