-
-
Notifications
You must be signed in to change notification settings - Fork 212
Add Nano 33 BLE PID for OpenMV firmware #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ ebd0c6f
Click for full report table
Click for full report CSV
|
Instead than adding another full-fledged target, I'd rather add
to the "main" entry. This won't show the nice label but won't increase maintenance either. |
ebd0c6f
to
8006569
Compare
Memory usage change @ 8006569
Click for full report table
Click for full report CSV
|
facchinm
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a variant for the Nano 33 BLE that allows us to expose a separate port from the OpenMV firmware. This will allow us to recognize if the board is running OpenMV without using any special tooling.
Instead of using
OpenMV
/_omv
in the naming we could also go withMicroPython
and_mp
.Thoughts? @facchinm