Skip to content

tone support no greater than 500Hz pitch #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lzq420241 opened this issue Nov 1, 2020 · 2 comments
Closed

tone support no greater than 500Hz pitch #84

lzq420241 opened this issue Nov 1, 2020 · 2 comments

Comments

@lzq420241
Copy link

ArduinoCore-mbed/cores/arduino/Tone.cpp

Line 27 in b0a3c08

ticker.attach(mbed::callback(this, &Tone::toggle), 500ms / frequency );

@lzq420241
Copy link
Author

better change 500ms to 500000us to support a higher pitch

@facchinm
Copy link
Member

facchinm commented Nov 2, 2020

Hi @lzq420241 ,
thanks for reporting, I thought std::chrono to be a bit smarter and apply the right operation (I was wrong 🙂 ).
Will fix in a minute!

sebromero pushed a commit to sebromero/ArduinoCore-mbed that referenced this issue Feb 2, 2022
@facchinm @sebromero
Tone: allow pitches higher than 500Hz
038e87a 
Fixes arduino#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lzq420241 @facchinm