Skip to content

Add "new" proxy header for compatibility with c++-standard #include<new> #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

Add "new" proxy header for compatibility with c++-standard #include<new> #340

merged 1 commit into from
Jun 11, 2020

Conversation

eudoxos
Copy link
Contributor

@eudoxos eudoxos commented May 13, 2020

See discussion in ETLCPP/etl#222 (comment) (breakage of ETL as #include fails).

@eudoxos eudoxos mentioned this pull request May 13, 2020
Closed
matthijskooijman
matthijskooijman approved these changes May 13, 2020
View reviewed changes
Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change to me. The lack of a full libstdc++ on AVR is annoying as it is, but this is an easy and small change that makes the AVR core a little bit more compliant.

@facchinm facchinm merged commit 71c3f99 into arduino:master Jun 11, 2020
@eudoxos eudoxos deleted the header-new branch June 11, 2020 20:23
This was referenced Sep 17, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eudoxos @matthijskooijman @facchinm