Skip to content

[TWI] Add __attribute__ ((fallthrough)) to remove recent GCC warnings #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

[TWI] Add __attribute__ ((fallthrough)) to remove recent GCC warnings #100

merged 1 commit into from
Sep 16, 2019

Conversation

CombiesGit
Copy link
Contributor

@CombiesGit CombiesGit commented Aug 16, 2019 •
edited
Loading

Added:
__attribute__ ((fallthrough));

Reason:

warning: this statement may fall through [-Wimplicit-fallthrough=]

@CombiesGit
Update twi.c
13bace4 
Added  __attribute__ ((fallthrough));
@facchinm
Copy link
Member

Hi @CombiesGit ,
thanks for the PR!
I'd ask you to replace the commit title to something like [TWI] Add __attribute__ ((fallthrough)) to remove recent GCC warnings and then I think we can merge it safely

@CombiesGit CombiesGit changed the title Update twi.c [TWI] Add __attribute__ ((fallthrough)) to remove recent GCC warnings Aug 20, 2019
@CombiesGit
Copy link
Contributor Author

Done

@aentinger aentinger merged commit 786e405 into arduino:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthijskooijman matthijskooijman matthijskooijman approved these changes

@facchinm facchinm facchinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CombiesGit @facchinm @matthijskooijman @aentinger