Fix recipe.ar.pattern to avoid warning at startup

[facchinm]

IDE 1.6.6 changed the paths for archive files and complains with a warning if the pattern needs to be rewritten.

[calvinatintel]

@kmsywula @bigdinotech @SidLeung @bbaltz505 Please review

[bigdinotech]

@calvinatintel looks correct to me

[bbaltz505]

In 1.6.5 on Windows, I get a compile error error. Is "archive_file_path" recognized parameter in 1.6.5 ?

C:\Users\babaltz\AppData\Roaming\Arduino15\packages\Intel-Test\tools\arc-elf32\1.6.4+1.0/bin/arc-elf32-ar rcs {archive_file_path} C:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp\WString.cpp.o C:\Users\babaltz\AppData\Roaming\Arduino15\packages\Intel-Test\tools\arc-elf32\1.6.4+1.0/bin/arc-elf32-gcc -nostartfiles -nodefaultlibs -nostdlib -static -Wl,-X -Wl,-N -Wl,-mARCv2EM -Wl,-marcelf -Wl,--gc-sections -TC:\Users\babaltz\AppData\Roaming\Arduino15\packages\Intel-Test\hardware\arc32\1.6.4+1.55\variants\arduino_101/linker_scripts/flash.ld -Wl,-Map,C:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp/sketch_nov18a.cpp.map -o C:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp/sketch_nov18a.cpp.elf -LC:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp -LC:\Users\babaltz\AppData\Roaming\Arduino15\packages\Intel-Test\hardware\arc32\1.6.4+1.55\variants\arduino_101 -Wl,--whole-archive -larc32drv_arduino101 -Wl,--no-whole-archive -Wl,--start-group -larc32drv_arduino101 -lc -lm -lgcc C:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp\sketch_nov18a.cpp.o C:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp\variant.cpp.o C:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp/core.a arc-elf32-gcc: error: C:\Users\babaltz\AppData\Local\Temp\build6245026174883238268.tmp/core.a: No such file or directory Error compiling.

[SidLeung]

Brian…

I have not seen “ {archive_file_path} “ as part of the input parameters to the ARC cross compiler. The symbol should have been expended into a file by the builder. An output from mind as follow,

C:\Users\sidneyle\AppData\Roaming\Arduino15\packages\Intel-Test\tools\arc-elf32\1.6.4+1.0/bin/arc-elf32-ar rcs C:\Users\sidneyle\AppData\Local\Temp\build1242165541007227762.tmp/core.a C:\Users\sidneyle\AppData\Local\Temp\build1242165541007227762.tmp\hooks.c.o

Sid

[bbaltz505]

@SidLeung On 1.6.6, the parameter does expand to:
'C:\Users\babaltz\AppData\Local\Temp\buildxxxxx.tmp/core.a'
On 1.6.5, it does not.

[SidLeung]

The compile log msg I sent you was done with IDE 1.6.4. So, both 1.6.4 & 1.6.6 can expand the environment symbol correctly.

[bbaltz505]

This post describes the problem I am seeing:
arduino/Arduino#4114

[SidLeung]

Brian:

I have not acquired enough knowledge to understand the entire description in the link. Was it pointing to the platform.txt file is not compatible between IDE versions?

Sid.

[facchinm]

The patch is intended for IDE >= 1.6.6 and is not backward compatible (as you noticed). Since the serial monitor timeout issue has been merged in master after 1.6.6, the first release suitable for 101 will be 1.6.7
If you wish to keep backwards compatibility simply drop this patch but a warning will be displayed any time you compile a sketch 😄

[bbaltz505]

Thanks Martino. Given the number of users that may still be on 1.6.5 (and maybe 1.6.4), I suggest we do not merge this patch.

[calvinatintel]

Closing the PR since it's not backward compatible

[calvinatintel]

Reopening since we're now supporting 1.6.6. We understand that this breaks 1.6.5.

[calvinatintel]

cherry-picked