Skip to content

Jira 836, Enumerate non connectable Peripherals in Central scan #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2017
Merged

Jira 836, Enumerate non connectable Peripherals in Central scan #459

merged 1 commit into from
Mar 3, 2017

Conversation

SidLeung
Copy link
Contributor

@SidLeung SidLeung commented Feb 24, 2017 •
edited
Loading

Added feature:

  • In Central mode, the BLE library should enumerate Peripheral
    that are non-connectable (eg beacon).

Code Mods:

  1. BLEDevice.cpp:
    • Add the call to get Manufacturer Data info from a
      Peripheral. Non-connectable device may only broadcast
      this info.
  2. BLEDevice.h:
    • Prototyping.
  3. BLEDeviceManager.cpp:
    • Delete the filter about non-connectable advertisement.
    • Added APIs, hasManufacturerData(), setManufacturerData(),
      hasManufacturerData(), to gain access to adv info
      of non-connectable Peripherals.

@SidLeung SidLeung self-assigned this Feb 24, 2017
@SidLeung SidLeung added this to the Deneb milestone Feb 24, 2017
@SidLeung
Copy link
Contributor Author

@bigdinotech @eriknyquist , please review the code change.

@russmcinnis @noelpaz , please perform system testing. You can verify this feature with a beacon or make a 101 non-connectable in the Characteristic.

russmcinnis
russmcinnis suggested changes Feb 28, 2017
View reviewed changes
Copy link
Contributor

@russmcinnis russmcinnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr 459 will not compile BLE because of a '1' at the start of BLEDeviceManager.h
57 libraries/CurieBLE/src/internal/BLEDeviceManager.h
@@ -1,4 +1,4 @@
-/* +1/*
BLE Device API BLE Device API
Copyright (c) 2016 Arduino LLC. All right reserved. Copyright (c) 2016 Arduino LLC. All right reserved.

russmcinnis
russmcinnis suggested changes Feb 28, 2017
View reviewed changes
Copy link
Contributor

@russmcinnis russmcinnis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr 459 will not compile BLE because of a '1' at the start of BLEDeviceManager.h
57 libraries/CurieBLE/src/internal/BLEDeviceManager.h
@@ -1,4 +1,4 @@
-/* +1/*
BLE Device API BLE Device API
Copyright (c) 2016 Arduino LLC. All right reserved. Copyright (c) 2016 Arduino LLC. All right reserved.

@SidLeung
Copy link
Contributor Author

@russmcinnis , merge error corrected, JSON regenerated. Please check out the Jira ticket.

@russmcinnis
Copy link
Contributor

Using the new json this has passed unit and system testing.

@SidLeung
Copy link
Contributor Author

SidLeung commented Mar 1, 2017

Code approved, testing complete, proceed with merging to main trunk.

@russmcinnis , please approve this PR.

@yashaswini-hanji , please merge this PR once PR #458 is merged. Thanks.

@SidLeung SidLeung force-pushed the Jira836 branch 2 times, most recently from 6fa8a89 to b6fe58e Compare March 1, 2017 06:16
@SidLeung SidLeung assigned russmcinnis and unassigned SidLeung Mar 1, 2017
@SidLeung
Copy link
Contributor Author

SidLeung commented Mar 1, 2017

Merge issue at parent PR #412, issue addressed, rebase and pushed a new PR.

@russmcinnis , please retest this feature with the newly generated JSON.

@yashaswini-hanji , will ping you once the PR is ready for merging to main trunk.

@russmcinnis
Copy link
Contributor

this passed system and unit testing @SidLeung can resolve

@russmcinnis russmcinnis assigned SidLeung and unassigned russmcinnis Mar 2, 2017
@SidLeung SidLeung force-pushed the Jira836 branch 2 times, most recently from c26a529 to 215641c Compare March 3, 2017 01:21
@SidLeung SidLeung assigned russmcinnis and unassigned SidLeung Mar 3, 2017
@SidLeung SidLeung mentioned this pull request Mar 3, 2017
Closed
@sgbihu @SidLeung
Jira 836, Enumerate non connectable Peripherals in Central scan …
3612e08 
Added feature:
  - In Central mode, the BLE library should enumerate Peripheral
    that are non-connectable (eg beacon).

Code Mods:
1. BLEDevice.cpp:
   - Add the call to get Manufacturer Data info from a
     Peripheral.  Non-connectable device may only broadcast
     this info.
2. BLEDevice.h:
   - Prototyping.
3. BLEDeviceManager.cpp:
   - Delete the filter about non-connectable advertisement.
   - Added APIs, hasManufacturerData(), setManufacturerData(),
     hasManufacturerData(), to gain access to adv info
     of non-connectable Peripherals.
@SidLeung
Copy link
Contributor Author

SidLeung commented Mar 3, 2017

Code approve, passed test, proceed with merging to main trunk.

@yashaswini-hanji , please merge this PR to main trunk and close out the Jira.

@SidLeung
Copy link
Contributor Author

SidLeung commented Mar 3, 2017

@russmcinnis , please approve this PR.

@russmcinnis
Copy link
Contributor

passed system and unit test

@ndgbuilder ndgbuilder merged commit 3612e08 into arduino:master Mar 3, 2017
@yashaswini-hanji
Copy link
Contributor

PR merged and Closed Jira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russmcinnis russmcinnis russmcinnis requested changes

@eriknyquist eriknyquist eriknyquist approved these changes

@bigdinotech bigdinotech Awaiting requested review from bigdinotech

@noelpaz noelpaz Awaiting requested review from noelpaz

Assignees
No one assigned
Labels
enhancement Under Review
Projects
None yet
Milestone
Deneb
Development

Successfully merging this pull request may close these issues.
6 participants
@SidLeung @russmcinnis @yashaswini-hanji @eriknyquist @ndgbuilder @sgbihu