Make String::move of an invalidated String result in an invalidated String #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinatintel
force-pushed
the
master
branch
from
ce97bd7 to
aaaf3db
Compare
|
@sandeepmistry an unrelated commit b329d08 has snuck in, can you fix it please? |
sandeepmistry
force-pushed
the
invalidated-string-move
branch
2 times, most recently
from
8f7303e to
1b9eb8e
Compare
|
@eriknyquist done, I've rebased as well. |
|
@sandeepmistry thanks. I think somebody messed up on our side cause that commit snuck into a few recent pull requests! Thank you for fixing it anyway. |
|
+1 for the fix, but @calvinatintel let's wait until after beta to merge this. |
calvinatintel
force-pushed
the
master
branch
from
aaaf3db to
1beffde
Compare
|
@sandeepmistry the git history glitch that was causing this issue in multiple PRs has been fixed. The good news is that nobody else has to fix their PR, but the bad news is that you have to rebase again. My apologies, this is completely my fault for asking you to fix it too early! |
sandeepmistry
force-pushed
the
invalidated-string-move
branch
from
1b9eb8e to
32d7a15
Compare
|
@eriknyquist no worries, I've rebased and pushed again. |
eriknyquist
approved these changes
Sep 15, 2016
|
cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of arduino/Arduino#5127 to 101 core.
Please see arduino/Arduino#5127 (comment) for more discussion of what this change fixes. Note: this change has also been integrated in the SAMD core in arduino/ArduinoCore-samd#153.