Skip to content

CurieBLE: characteristic.read() does not block #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sandeepmistry opened this issue Dec 30, 2016 · 5 comments
Closed

CurieBLE: characteristic.read() does not block #383

sandeepmistry opened this issue Dec 30, 2016 · 5 comments
Assignees
@sandeepmistry
Labels
Under Review
Milestone
Deneb

Comments

@sandeepmistry
Copy link
Contributor

When trying the peripheral explorer example, I removed the delay(1000); statement inside the exploreCharacteristic as it was not in the original sample sketch we provided. When this was done the characteristic values were not printed to the Serial Monitor:

Before:

BLE Central - Peripheral Explorer
Found C8:69:CD:41:84:A2 '' 
Found E4:1E:14:D2:31:E7 '' 
Found AC:BC:32:7C:FA:26 'test1' ffffffff-ffff-ffff-ffff-fffffffffff0
Connecting ...
Connected
Discovering attributes ...
Attributes discovered

Device name: 
Service 1800
Service 1801
Service 180a
	Characteristic 2a29, properties 0x2, value 0x4170706C6520496E63
	Characteristic 2a24, properties 0x2, value 0x4D6163426F6F6B50726F31322C31
Service d0611e78-bbb4-4591-a5f8-487910ae4366
	Characteristic 0000, properties 0x24
Service ffffffff-ffff-ffff-ffff-fffffffffff0
	Characteristic 0000, properties 0x2, value 0x76616C7565
	Characteristic 0000, properties 0x2, value 0x64796E616D69632076616C7565
	Characteristic 0000, properties 0x2, value 0x000102030405060708090A0B0C0D0E0F10111213
	Characteristic 0000, properties 0x12
	Characteristic 0000, properties 0x16
	Characteristic 0000, properties 0x32

Disconnecting ...
Disconnected

After removing delay:

BLE Central - Peripheral Explorer
Found E4:1E:14:D2:31:E7 '' 
Found C8:69:CD:41:84:A2 '' 
Found C8:69:CD:41:84:A2 '' 
Found AC:BC:32:7C:FA:26 'test1' ffffffff-ffff-ffff-ffff-fffffffffff0
Connecting ...
Connected
Discovering attributes ...
Attributes discovered

Device name: 
Service 1800
Service 1801
Service 180a
	Characteristic 2a29, properties 0x2
	Characteristic 2a24, properties 0x2
Service d0611e78-bbb4-4591-a5f8-487910ae4366
	Characteristic 0000, properties 0x24
Service ffffffff-ffff-ffff-ffff-fffffffffff0
	Characteristic 0000, properties 0x2
	Characteristic 0000, properties 0x2
	Characteristic 0000, properties 0x2
	Characteristic 0000, properties 0x12
	Characteristic 0000, properties 0x16
	Characteristic 0000, properties 0x32

Disconnecting ...
Disconnected

Once this is fixed, the delay(1000); statement should be removed from the sketch.
@eriknyquist eriknyquist added this to the Deneb milestone Dec 30, 2016
@SidLeung
Copy link
Contributor

SidLeung commented Jan 6, 2017

The previous release, v1.0.7, BLE implementation employed end-to-end command/reply handshaking for each operation (read, write, etc). Thus, the overall BLE performance was substantially impacted. The latest BLE library uses the request/query approach that enables non-blocking operation to improve performance and bandwidth utilization.

To be backward compatible, may need to introduce a bool flag, as an input parameter, for blocking call selection. By default, an operation will be blocking.

This request for change is logged as Jira 795.

@sandeepmistry
Copy link
Contributor Author

@SidLeung

To be backward compatible, may need to introduce a bool flag, as an input parameter, for blocking call selection. By default, an operation will be blocking.

I'm confused, there was no read operation in v1.0.7. So, I expect it to always block.

@sgbihu
Copy link
Contributor

sgbihu commented Jan 12, 2017

The read is for central to read attributes.

sgbihu added a commit to sgbihu/corelibs-arduino101 that referenced this issue Jan 18, 2017
@sgbihu
Jira 795 Make read / write calls to be blocking, git issue arduino#383
6ea995d 
1. Add the parameter of read to support block/unblock call.
2. Changed file list
    libraries/CurieBLE/src/BLECharacteristic.cpp
    libraries/CurieBLE/src/BLECharacteristic.h
    libraries/CurieBLE/src/internal/BLECallbacks.cpp
    libraries/CurieBLE/src/internal/BLECharacteristicImp.cpp
    libraries/CurieBLE/src/internal/BLECharacteristicImp.h
sgbihu added a commit to sgbihu/corelibs-arduino101 that referenced this issue Jan 18, 2017
@sgbihu
Jira 795 Make read / write calls to be blocking, git issue arduino#383
caf5c62 
1. Add the parameter of read to support block/unblock call.
2. Changed file list
    libraries/CurieBLE/src/BLECharacteristic.cpp
    libraries/CurieBLE/src/BLECharacteristic.h
    libraries/CurieBLE/src/internal/BLECallbacks.cpp
    libraries/CurieBLE/src/internal/BLECharacteristicImp.cpp
    libraries/CurieBLE/src/internal/BLECharacteristicImp.h
@sgbihu sgbihu mentioned this issue Jan 18, 2017
Closed
@SidLeung
Copy link
Contributor

SidLeung commented Feb 8, 2017

Resolution passed code review, system testing, and merged to main trunk. Will be in the next nightly JSON build.

@kitsunami kitsunami assigned sandeepmistry and unassigned noelpaz and SidLeung Feb 24, 2017
@sandeepmistry
Copy link
Contributor Author

Testing with the 2.0.1 RC1 release, this is now fixed. Closing.

BLE Central - Peripheral Explorer
Found 69:0D:D0:1D:01:B8 '' 
Found 69:0D:D0:1D:01:B8 'PizzaSquat' 
Connecting ...
Connected
Discovering attributes ...
Attributes discovered

Device name: 
Service 1800
Service 1801
Service 180a
	Characteristic 2a29, properties 0x2, value 0x4170706C6520496E63
	Characteristic 2a24, properties 0x2, value 0x4D6163426F6F6B50726F31322C31
Service d0611e78-bbb4-4591-a5f8-487910ae4366
	Characteristic 8667556c-9a37-4c91-84ed-54ee27d90049, properties 0x24
Service 9fa480e0-4967-4542-9390-d343dc5d04ae
	Characteristic af0badb1-5b99-43cd-917a-a77bc549e3cc, properties 0x24
Service 13333333-3333-3333-3333-333333333337
	Characteristic 13333333-3333-3333-3333-333333330001, properties 0x10, value 0x00
		Descriptor 2901, value 0x
	Characteristic 13333333-3333-3333-3333-333333330002, properties 0x10
		Descriptor 2901, value 0x
	Characteristic 13333333-3333-3333-3333-333333330003, properties 0x24
		Descriptor 2901, value 0x

Disconnecting ...
Disconnected

@sandeepmistry sandeepmistry mentioned this issue Mar 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandeepmistry sandeepmistry

Labels
Under Review
Projects
None yet
Milestone
Deneb
Development

No branches or pull requests
5 participants
@sandeepmistry @eriknyquist @noelpaz @SidLeung @sgbihu