Closed
Description
I'm in the process of collaborating with some other folks to build a new Arduino port for GigaDevice's GD32 chips[1]. We're attempting to build on top of ArduinoCore-API. In general, It's so much better than the old way of doing things. One thing we're running into is how to handle gaps in the PinMode enum.
Specifically, we're short an OUTPUT_OPENDRAIN
in PinMode
Would a PR that adds a new OUPUT_OPENDRAIN = 0x4
to the PinMode definition be welcome? If not, is there an alternate "Arduinoish" way to build the user-facing API to set a pin as an open-drain output?
[1] https://github.com/CommunityGD32Cores/ArduinoCore-GD32
Thanks!
Metadata
Metadata
Assignees
Labels
No labels
Activity
facchinm commentedon Sep 22, 2021
I'm totally 👍 to add the
OUTPUT_OPENDRAIN
define; would you mind to file a PR with the change?Add a new 'OUTPUT_OPENDRAIN' pinmode for platforms.
obra commentedon Sep 22, 2021
Done as #157, with copious notes for the next person who needs to work around lack of some pin mode in the commit message ;)
Based on the implementation of Analog pins in the Arduino world, I'm guessing that a standard "INPUT_ANALOG" PinMode is not of general interest?
Add a new 'OUTPUT_OPENDRAIN' pinmode for platforms.