Fixed incorrect encoding of compiler log #8289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes #8212 by passing '-Dfile.encoding=UTF8' to the arduino.l4j.ini file (windows launcher). This property define the file encoding that is required.
|
We should test it on all platforms to avoid regressions or unexpected behaviors. |
|
LGTM! Applying to other platforms (eg OSX) could be much more difficult but in the meantime it should be fine on win at least! Merging |
|
Do we have any idea what this setting changes exactly? I wonder if we should be specifying the encoding when opening streams and files instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #8212 by passing '-Dfile.encoding=UTF8' to the arduino.l4j.ini file (windows launcher).
This property define the file encoding (UTF-8) that is required.