Skip to content

Added comment to address A-Style Autoformatter #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jul 18, 2019
Merged

Added comment to address A-Style Autoformatter #7550

merged 2 commits into from Jul 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 2, 2018

Addresses issue #5012 which discusses auto format and preferences.txt. This will help others find the correct file to edit for A-Style.

@matthijskooijman
Copy link
Collaborator

Sounds like a good addition. However, you now write "DO NOT CHANGE THIS FILE if you want to edit autoformatter", which suggests that preferences.txt contains autoformatter settings, but you shouldn't change them. Rather, I think that preferences.txt does not contain such settings, and it might be better to write something like "This file does not contain autoformatter settings. Instead... " etc.

If you want to update this PR, note that you can amend your commit and do a force push to replace the current contents of this PR, there is no need to create a new PR.

@ghost
Copy link
Author

ghost commented May 3, 2018

Thank you for your suggestion! I have edited the file with the altered message. Is there anything else I should do?

Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

It might be good to squash these two changes in a single commit, though that can also be done by @facchinm or @cmaglie when merging the PR.

@facchinm facchinm merged commit 9a63965 into arduino:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants