-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Make "find and replace" window always appear on top of the parent editor #6603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I'm sorry, but now I understand your reply, it is ashamed. |
Hi @czghzc , |
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6603-BUILD-732-linux32.tar.xz ℹ️ The |
Hi @facchinm , |
If the editor is focused, acquire alwaysOnTop capabilities but drop them as soon as both the editor and the dialog are out of focus
As implemented in Notepad++, a partially transparent search/replace window could make it easier to interact with the editor (particularly in fullscreen contexts, when the "always on top" window could hide the search results). Unfortunately, Java can only apply the transparency to undecorated window, so it's a no-go. Java gurus, please come to the rescue :D
Probably this approach could be adopted by all OSes with a little care on the window lifecycle.
09f5196
to
71418ca
Compare
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6603-BUILD-740-linux32.tar.xz ℹ️ The |
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6603-BUILD-742-linux32.tar.xz ℹ️ The |
With 6603 the behavior is noticeably better, for doggone sure! (Linux Mint) Only thing is, still, I when I file-save via the menu dropdown, the "find" window still goes behind right when I select the final menu selection and stays there. I some other menu selections do the same (some in help menu, at least), but others (save-as, for example) work the "find" window just fine. |
I agree with causing the text to be selected when re-pressing ctrl-f. I just thought you had a reason for not having it that way in the first place. Otherwise oftentimes a person enters new test unintentionally appending to previous. Additionally, you could replace the text with any text currently selected in the main window, just like when the search gets newly activated. |
Fixes #6408 and #4883