Skip to content

Two fix for future Windows compatibility #6331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2017
Merged

Two fix for future Windows compatibility #6331

merged 2 commits into from
May 30, 2017

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 29, 2017

  • avoid .dll unpacking for JSSC (only when running on windows)
  • to open help references use win32 API ShellExecute instead of running cmd.exe if possible

@cmaglie cmaglie added the in progress Work on this item is in progress label May 29, 2017
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6331-BUILD-692-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6331-BUILD-692-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6331-BUILD-692-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6331-BUILD-692-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6331-BUILD-692-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@cmaglie cmaglie merged commit d65e6ff into arduino:master May 30, 2017
@cmaglie cmaglie removed the in progress Work on this item is in progress label May 30, 2017
@cmaglie cmaglie deleted the jssc-no-unpack branch May 30, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @ArduinoBot