Change double quotes to single quotes #5815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijskooijman
approved these changes
Jan 7, 2017
NicoHood
approved these changes
Jan 7, 2017
- "." is a string literal, and so is treated as the char '.' plus the null char '\0'. - Single quotes reduces the necessary memory for this literal to only one char instead. A string literal as the one actually present may require the use of the method "write(const char *str)", so there could be also a performance overhead. - Another reason to change quotes style is for consistency with line 235. Signed-off-by: Patrick Roncagliolo <[email protected]>
Signed-off-by: Patrick Roncagliolo <[email protected]>
|
My commits now appear after @matthijskooijman's and @NicoHood's approvals because I signed-off them only this evening, and so the original hashes have changed. Sorry for the inconvenient. Feel free to double-check content, no variations were made from original commits. |
|
@roncapat What do you mean by signed off? They are not GPG signed or at least if they are you miss-configured github. |
matthijskooijman
approved these changes
Jan 8, 2017
|
First two patches looks really good, while I'd avoid merging the GSM related patch (maybe opening another PR on https://github.com/arduino-libraries/GSM is more appropriate) |
|
Let me know if I have to squash the first two commits and pop-out the last
one in order to have only the patch(es) you indicated, or something else.
In the next hours I'll then submit the last patch to GSM library repo.
|
|
Simply force pushing on the same branch after removing the GSM related patch is ok IMO |
|
Done. Here are only the patches for core library. |
|
Merged, thanks! |
ollie1400
pushed a commit
to ollie1400/Arduino
that referenced
this pull request
May 2, 2022
Change double quotes to single quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observe that "." is a string literal, and so is treated as the char '.' plus the null char '\0'. Single quotes reduces the necessary memory for this literal to only one char instead.
A string literal as the one actually present may require the use of the method "write(const char *str)", so there could be also a performance overhead.
Another reason to change quotes style is for consistency with line 235.
Signed-off-by: Patrick Roncagliolo [email protected]